-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move docs generations to bazel distribution #393
Merged
flyingsilverfin
merged 6 commits into
typedb:master
from
krishnangovindraj:move-docs-to-bazel-distribution
Jan 12, 2024
Merged
Move docs generations to bazel distribution #393
flyingsilverfin
merged 6 commits into
typedb:master
from
krishnangovindraj:move-docs-to-bazel-distribution
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
This was referenced Dec 21, 2023
780aa76
to
db985cd
Compare
</pre> | ||
|
||
|
||
Creates HTML documentation for C++ projects using Doxygen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs should note that Doxygen must be installed externally - this is not a hermitic rule.
flyingsilverfin
approved these changes
Jan 12, 2024
flyingsilverfin
approved these changes
Jan 12, 2024
flyingsilverfin
pushed a commit
to typedb/typedb-dependencies
that referenced
this pull request
Jan 12, 2024
## What is the goal of this PR? Moves docs generation rules & tools to the bazel-distribution repository ## What are the changes implemented in this PR? * Moves doc generation rules & tools to bazel-distribution * Bumps the dependency on bazel-distribution. PR chain: typedb/typedb-driver#552 > #491 > typedb/bazel-distribution#393
flyingsilverfin
pushed a commit
to typedb/typedb-driver
that referenced
this pull request
Jan 12, 2024
## Usage and product changes Moves bazel rules used for generating documentation into the vaticle/bazel-distribution repository ## Implementation * Updates BUILD files to reflect moving converters for {doxygen, javadoc, sphinx (python), rustdocs} into bazel-distribution PR chain: #552 > typedb/typedb-dependencies#491 > typedb/bazel-distribution#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Moves bazel rules used for generating documentation into the vaticle/bazel-distribution repository
What are the changes implemented in this PR?
PR chain: typedb/typedb-driver#552 > typedb/typedb-dependencies#491 > #393