Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor apt packaging to use new pkg_rules rules #390

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Refactor apt packaging to use new pkg_rules rules #390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac74d97
Use new pkg_tar rules
flyingsilverfin Oct 3, 2023
de6e3ff
Cleanup unused lines
flyingsilverfin Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions apt/rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#

load("@rules_pkg//:pkg.bzl", "pkg_tar", "pkg_deb")
load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_mkdirs")
load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_mkdirs", "pkg_mklink", "pkg_filegroup", "pkg_files")

def _assemble_apt_version_file_impl(ctx):
version = ctx.var.get('version', '0.0.0')
Expand Down Expand Up @@ -99,15 +99,38 @@ def assemble_apt(name,
dirs = empty_dirs
)

symlink_names = []
for link, target in symlinks.items():
print(link, target)
symlink_name = "_{}-{}".format(name, link.replace("/", "_").replace("\\", "_"))
symlink_names.append(symlink_name)
pkg_mklink(
name = symlink_name,
link_name = link,
target = target
)

archives_merged_name = "_{}_archives".format(name)
pkg_tar(
name = archives_merged_name,
package_dir = installation_dir,
deps = archives # using deps instead of sources will merge tars into a single tar
)

files_name = "_{}_files".format(name)
pkg_files(
name = files_name,
prefix = installation_dir,
srcs = files.keys(),
renames = files,
)

pkg_tar(
name = tar_name,
extension = "tar.gz",
deps = archives,
package_dir = installation_dir,
srcs = [empty_dirs_name],
files = files,
srcs = [empty_dirs_name] + symlink_names + [files_name],
mode = "0755",
symlinks = symlinks,
deps = [archives_merged_name],
modes = permissions,
)
deb_data = tar_name
Expand Down