Add suggested values for variable dropdown #9437
Conversation
| @@ -13,8 +13,7 @@ export type ServerlessFunctionTestData = { | |||
| height: number; | |||
| }; | |||
|
|
|||
| export const DEFAULT_OUTPUT_VALUE = | |||
| 'Enter an input above then press "run Function"'; | |||
| export const DEFAULT_OUTPUT_VALUE = 'Enter an input above then press "Test"'; | |||
There was a problem hiding this comment.
updated since button is named Test
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds suggested values for workflow variable dropdowns, displaying contextual preview values for simple fields while maintaining a clean hierarchical structure for composite fields.
- Added contextual preview values in
WorkflowVariablesDropdownFieldItems.tsxusingsubStep?.value?.toString()for leaf nodes - Modified
generate-fake-value.tsto provide realistic example values like "Tim Cook" for FULL_NAME and "123 Main St" for ADDRESS fields - Updated
MenuItemSelectandMenuItemLeftContentcomponents to support contextual text display with proper text overflow handling - Changed default output message in
serverlessFunctionTestDataFamilyState.tsto "Enter an input above then press 'Test'" - Fixed non-breaking space character issue in
MenuItemLeftContent.tsxtemplate literal
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| return objData; | ||
| } else if (valueType === FieldMetadataType.TEXT) { | ||
| return 'My text'; | ||
| return objData.toString(); |
There was a problem hiding this comment.
i don't get the toString either...
There was a problem hiding this comment.
Maybe can we use JSON.stringify() instead of toString() ?
There was a problem hiding this comment.
nope this is a mistake. At some point I was trying to convert on backend side
|
|
||
| export const generateFakeValue = (valueType: string): FakeValueTypes => { | ||
| type TypeClassification = 'primitive' | 'FieldMetadataType'; |
There was a problem hiding this comment.
| type TypeClassification = 'primitive' | 'FieldMetadataType'; | |
| type TypeClassification = 'primitive' | 'fieldMetadataType'; |
|
|
||
| export const generateFakeValue = (valueType: string): FakeValueTypes => { | ||
| type TypeClassification = 'primitive' | 'FieldMetadataType'; |
There was a problem hiding this comment.
or
| type TypeClassification = 'primitive' | 'FieldMetadataType'; | |
| type TypeClassification = 'Primitive' | 'FieldMetadataType'; |
| return objData; | ||
| } else if (valueType === FieldMetadataType.TEXT) { | ||
| return 'My text'; | ||
| return objData.toString(); |
There was a problem hiding this comment.
Maybe can we use JSON.stringify() instead of toString() ?
Here is a first version: