[WIP]: Blocklist V2 #9435
Draft
[WIP]: Blocklist V2 #9435
+377
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacyL2K19
force-pushed
the
feat/blocklist-v2
branch
from
802ef9a to
b1d8d97
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a comprehensive blocklist management system with multi-level blocking capabilities (From/To, Cc, Bcc) and context-based state management.
- Critical bug: Empty handler functions passed in
SettingsAccountsBlocklistSection.tsxBlocklistContext.Provider instead of actual implementations - Added validation schema in
SettingAccountBlocklistContactRow.tsxfor email/domain inputs with proper error handling - New
BlocklistItemtype includes optional 'levels' property for granular blocking control - Implemented multi-select dropdown in
SettingAccountBlocklistContactRow.tsxfor configuring blocking levels - Created container architecture with
SettingAccountsBlocklistContainer.tsxfor better component organization
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
8 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
...s/twenty-front/src/modules/settings/accounts/components/SettingsAccountsBlocklistSection.tsx
Show resolved
Hide resolved
.../twenty-front/src/modules/settings/accounts/components/SettingAccountsBlocklistContainer.tsx
Show resolved
Hide resolved
.../twenty-front/src/modules/settings/accounts/components/SettingAccountsBlocklistContainer.tsx
Show resolved
Hide resolved
.../twenty-front/src/modules/settings/accounts/components/SettingAccountBlocklistContactRow.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/accounts/contexts/BlocklistContext.ts
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| export type OptionalString = string | null; | |||
There was a problem hiding this comment.
style: Consider using undefined instead of null to align with TypeScript best practices, as undefined is more commonly used for optional values
| @@ -0,0 +1,6 @@ | |||
| export enum BlocklistContactLevel { | |||
| ALL = 'All', | |||
| FROMTO = 'From/To', | |||
There was a problem hiding this comment.
style: consider using 'FROM_TO' instead of 'FROMTO' to follow common enum naming conventions
charlesBochet
added
-PR: wip
blocked: conflict/dependency
and removed
blocked: conflict/dependency
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP
Fixing #8831