Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid clipping by aggregate footer #9403

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mdrazak2001
Copy link
Contributor

fixes #9352
image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This change increases the z-index of table cell edit mode containers to prevent popup content from being clipped by the aggregate footer row.

  • Modified packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx to increase z-index from 1 to 6 for StyledEditableCellEditModeContainer
  • Ensures proper visibility of popups (datetime, select, relation fields etc.) when editing the last record in tables with aggregation rows

💡 (5/5) You can turn off certain types of comments like style here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ijreilly ijreilly merged commit 3198748 into twentyhq:main Jan 8, 2025
21 checks passed
Copy link

github-actions bot commented Jan 8, 2025

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-8d76f333.json

Generated by 🚫 dangerJS against ad4909d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last record data popups in table are cut thanks to aggregations invisible row
3 participants