Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor active navigation drawer item label font color fix #9356

Conversation

ehconitin
Copy link
Contributor

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Improved color inheritance for navigation drawer items by centralizing color logic in the parent component for better visual consistency.

  • Removed explicit color styling from StyledEllipsisContainer and StyledItemLabel in NavigationDrawerItem.tsx
  • Consolidated color state handling (active, danger, soon) in StyledItem component
  • Fixed label colors not properly reflecting active/hover states

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@lucasbordeau lucasbordeau self-assigned this Jan 6, 2025
@lucasbordeau
Copy link
Contributor

Main :

image

This branch :

image

Text is primary, is it what we want @Bonapara ?

@ehconitin
Copy link
Contributor Author

@lucasbordeau according to figma
Yes :)

@ehconitin ehconitin merged commit 4f7fa7a into twentyhq:main Jan 7, 2025
21 checks passed
Copy link

github-actions bot commented Jan 7, 2025

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-ca6149c9.json

Generated by 🚫 dangerJS against c3b09ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants