Start simplification module with VW simplification #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vertex/edge/facedata
Adapt regionMapToArrangement() to the new, templated version of RegionArrangement. Unfortunately this means that this function too has to become a function template, and hence it had to be pulled to the header file.
….com/tue-alga/cartocrow.git into SimplificationBranch
…ogy checks, untested
* created a demo * renamed the generic case to vertex removal * generalized traits to also abstract from the vertex data type * fixed bugs
- fixed bugs - added historic arrangement, such that simplify() calls can also go back up in complexity - updated demo
- pulled the history out of the simplification class, s.t. you can keep the history without the simplification object - made the simplification class not require a historic arrangement, but can use it, if provided - added an oblivious arrangement that does not keep a history - added concepts for the templates
- Code cleanup - Simplifying to threshold - Providing some first, basic comments in all files
… SimplificationBranch
…ed long template implementations into separate files
…orming to standards
For some reason, the order in which libraries are linked matters. Interestingly enough, linking with mold works regardless of the order.
- batched operations in historic arrangement - allowing shifting of vertices (in prep of other algorithms) - util functions changed to modify not just one object, but everything around it * this is to keep a consistent geometry; the util functions are now one-invoke to achieve what is necessary, rather than puzzling out which edges, vertices, etc, had to move in conjunction
…rtocrow.git into SimplificationBranch
…started on splits necessary for BMRS
…ompilable again. Culled isoline_simplification from cmake files, since it didn't compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.