Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates CLI to use https flag #814

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

Chigala
Copy link
Contributor

@Chigala Chigala commented Dec 27, 2023

Closes #801

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

I started my NextJs server using the --experimental https flag with the nextjs project in the references folder and the used the -https flag on the CLI and it workded, then I also tested the CLI without the flag on the nextJs server not running https and it also worked.

Changelog

NIL

Screenshots

Screenshot 2023-12-26 at 8 39 40 PM

💯
Screenshot 2023-12-26 at 8 40 51 PM

I'll love your feedbacks on this

Copy link

changeset-bot bot commented Dec 27, 2023

🦋 Changeset detected

Latest commit: 3fdcd4c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Frumba
Copy link

Frumba commented Jan 12, 2024

Hey ! Can't wait to get this merged onto main branch to finally use it 🙏

Copy link
Member

@matt-aitken matt-aitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍

This needs testing on:

  • A regular Next.js project
  • A Next.js project with HTTPS enabled

@matt-aitken
Copy link
Member

Thanks a lot @Chigala, this is great 😄

@matt-aitken matt-aitken merged commit bc61d83 into triggerdotdev:main Jan 12, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRI-1786] CLI dev command should have a flag for https
3 participants