Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isDefinedArray): add isDefinedArray #928

Closed
wants to merge 3 commits into from

Conversation

HANYUNSEONG
Copy link

Add isDefinedArray function

@HANYUNSEONG HANYUNSEONG requested a review from raon0211 as a code owner January 6, 2025 08:18
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:38am

@raon0211
Copy link
Collaborator

Hello :) Thanks for opening a pull request! I see what this function is doing, but I think using arr.every(x => x !== undefined && x !== null) is a bit more explicit and less likely to cause confusion. There can be different interpretations of what a "defined array" really means, so I feel it might be clearer to stick with the native array methods directly. What do you think?

@raon0211
Copy link
Collaborator

Closing the pull request for now :)

@raon0211 raon0211 closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants