Changing file permissions to be uniform across all frequencies #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the permissions for daily, hourly, and monthly are all 0644, while weekly is 0640. Recommending it is updated to 0644 to be uniform across the board unless there is a particular reason weekly should be different.
|
Please note that the checks failing has nothing to do with this PR itself. Recommended this be pulled into master so that it does not impact future consumers of this module. |
|
+1 |
|
@jrk07 Just curious, what's your rationale for 644 vs. 640? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the permissions for daily, hourly, and monthly are all 0644, while weekly is 0640. Recommending it is updated to 0644 to be uniform across the board unless there is a particular reason weekly should be different.
This change is