Skip to content

Commit

Permalink
Revert "Placate heroku-audit"
Browse files Browse the repository at this point in the history
This reverts commit 33be46b.

Fixed with version 0.0.3
  • Loading branch information
RealOrangeOne committed Nov 20, 2024
1 parent 2451acc commit 36e0843
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Formula/buckup.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class Buckup < Formula
depends_on "python@3"

def install
# without_pip is deprecated in python 3.12+, so we only pass it for older versions
if Language::Python.major_minor_version("python3") >= "3.12"
# `without_pip` is replaced with `ensurepip` in python 3.12+
venv = virtualenv_create(libexec, "python3")
system libexec/"bin/python", "-m", "ensurepip"
else
Expand Down
7 changes: 3 additions & 4 deletions Formula/heroku-audit.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class HerokuAudit < Formula
depends_on "python@3"

def install
# without_pip is deprecated in python 3.12+, so we only pass it for older versions
if Language::Python.major_minor_version("python3") >= "3.12"
# `without_pip` is replaced with `ensurepip` in python 3.12+
venv = virtualenv_create(libexec, "python3")
system libexec/"bin/python", "-m", "ensurepip"
else
Expand All @@ -24,8 +24,7 @@ def install

test do
assert_predicate bin/"heroku-audit", :exist?
# TODO: Re-add this once https://github.com/torchbox/heroku-audit/issues/5 is fixed
# system bin/"heroku-audit", "--list"
# assert_match "Heroku Audit v#{version}", shell_output("#{bin}/heroku-audit --version")
system bin/"heroku-audit", "--list"
assert_match "Heroku Audit v#{version}", shell_output("#{bin}/heroku-audit --version")
end
end

0 comments on commit 36e0843

Please sign in to comment.