Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alternate lang tags, x-default, translations, nullpointer on dev, documentation, locale-encoding #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leobardimpact
Copy link

  • only include translations that exist,
  • add rel=alternate,
  • x-default should be neutral according to spec
  • both in Meta and sitemap
  • adding documentation to code with links to relevant standardization documents
  • return standard-conforming hreflang encoding for tags for rel=alternate and locales for og:locale, removing .utf8 encodings and transforming "-" and "_" as necessary
  • fixing nullpointer in sitemap reading App::plugin('tobimori/seo')->version() when installing branches during development

Based on these pull requests, incorporating them

Fixes:

Maybe @FlorianBoe and @timnarr, could you review and confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants