Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加设置slider跟navigationbar背景图片,增加给Array动态赋值 #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wangxumin
Copy link

No description provided.

@tingxins
Copy link
Owner

tingxins commented Dec 3, 2017

Review 了下代码,功能基本没什么问题,下一个迭代版本可合并,但还有几处需修改一下哈:

  • 此 PR 修改了工程相关配置
  • Commit message 格式没对齐(可参考历史提交记录)
  • 不同功能建议分多次 PR,包括 Demo 的修改也是。

感谢支持。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants