Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate creation of the same table #465

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

YangYumings
Copy link
Contributor

@YangYumings YangYumings commented Nov 27, 2024

Problem phenomenon:

The table model repeatedly registers the same table during the metadata registration phase, resulting in a long overhead in the metadata registration phase.

image

Reason:

  • Multiple threads are responsible for "registered tables" and there will be conflicts;
  • A single thread performs a "registry operation" for each device;

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit f2826ee into thulab:master Nov 28, 2024
1 check passed
YangYumings added a commit to YangYumings/iot-benchmark that referenced this pull request Nov 28, 2024
* Prevent duplicate creation of the same table

* One thread is responsible for creating all the tables.

* Collect all table names.

* spotless:apply

* Each thread creates the table that it is responsible for.

* Each thread creates the table that it is responsible for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants