Commit appraisals gemfile locks #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why the gemfile locks from appraisals weren't being included. But they are helpful to keep - just like the main Gemfile. I don't see why not committing them. Open to be convinced of the contrary though.
|
If this one gets merged, we don't need to poke with CI to verify the issue is with our appraisals not having been updated with the latest railties versions @sej3506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why the gemfile locks from appraisals weren't being included.
But they are helpful to keep - just like the main Gemfile.
I don't see why not committing them. Open to be convinced of the contrary though.