Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43 added typescript support #55

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

Felix-Franz
Copy link
Contributor

@Felix-Franz Felix-Franz commented Jun 22, 2021

According to #43 I have created an index.d.ts and included it in the package.json, but I am not 100% sure if this works if the package is published to the npm registry.
The easiest way to check this is to test it after it is published to the npm.

@this-fifo
Copy link
Owner

thanks @Felix-Franz , ideally we would want to avoid having any types, but that would require maintaining the values supported by Jitsi. This is a good start as it already adds value 🙇‍♂️

@this-fifo this-fifo merged commit fabf51f into this-fifo:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants