Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure PHP / Spiral app #8228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Configure PHP / Spiral app #8228

wants to merge 1 commit into from

Conversation

roxblnfk
Copy link

  • removed unused modules
  • configure web server for production

@roxblnfk roxblnfk requested a review from waghanza as a code owner February 10, 2025 20:10
waghanza
waghanza reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I am thrilled to have production ready implementations here.

May I ping you for any (minor or spec change) update on spiral here ? Renovatebot updates each minor

php/spiral/.rr.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file suitable for all frameworks using road runner ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ping you for any (minor or spec change) update on spiral here ? Renovatebot updates each minor

Of course. I don't think there will be any problems with updating minor versions, but if there are, feel free to reach out.
Also, feel free to contact me if you are expanding test cases for FullStack frameworks that involve data handling.

Is this file suitable for all frameworks using road runner ?

Yes. If you don't want to test the console's throughput, it's better not to log every request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waghanza waghanza waghanza left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roxblnfk @waghanza