-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resize mode cover/contain #644
Changes from 1 commit
4b99c7d
e6b108e
3e7fefa
8978035
2e55147
c05d4d2
67ad01c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,6 +105,19 @@ public enum ZoomMode: Int, CustomStringConvertible { | |
} | ||
} | ||
|
||
@objc(CKResizeMode) | ||
public enum ResizeMode: Int { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we make it consistent with the other ones, like the one above? No There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @lichstam what about this one? |
||
case cover = 0 | ||
case contain = 1 | ||
|
||
public var stringValue: String { | ||
switch self { | ||
case .cover: return "cover" | ||
case .contain: return "contain" | ||
} | ||
} | ||
} | ||
|
||
@objc(CKSetupResult) | ||
enum SetupResult: Int { | ||
case notStarted | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we do
.contain
here, and.cover
in CameraView? Seems like we should havecontain
for all default values to keep things consistent (and say so in the doc)