Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly_requirements.txt #11013

Closed
wants to merge 3 commits into from

Conversation

johnnynunez
Copy link

Description

📝 Please include a summary of the change.

  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

📝 Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Test Configuration:

Checklist

@laxmareddyp laxmareddyp added the models:official models that come under official repository label Jun 7, 2023
Copy link
Member

@saberkun saberkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to bump the versions?

@johnnynunez
Copy link
Author

Why do we need to bump the versions?

Why do we need to bump the versions?

breaks https://github.com/tensorflow/benchmarks

@saberkun
Copy link
Member

Does the new Dockerfile_ubuntu_2004_tf_cuda_11 solve the problem?

@johnnynunez
Copy link
Author

Does the new Dockerfile_ubuntu_2004_tf_cuda_11 solve the problem?

is my PR too, it's working for me

@laxmareddyp laxmareddyp requested a review from Chen-Zhe November 30, 2023 17:33
Chen-Zhe
Chen-Zhe previously approved these changes Nov 30, 2023
@laxmareddyp laxmareddyp added the ready to pull ready to pull (create internal pr review and merge automatically) label Dec 6, 2023
@laxmareddyp
Copy link
Collaborator

@johnnynunez ,

Could you please resolve the conflicts.

Thanks.

@laxmareddyp laxmareddyp removed the ready to pull ready to pull (create internal pr review and merge automatically) label Dec 8, 2023
@laxmareddyp laxmareddyp requested review from Chen-Zhe and removed request for rachellj218 December 8, 2023 22:55
@laxmareddyp
Copy link
Collaborator

HI @johnnynunez ,

With current versions in the nightl_ requirements.txt is aligned and working with latest changes in the across all libraries.

In future, please open an issue and discuss with us before submitting a pull request. If the change does not align with our best practices, we can provide early feedback. Please review guidelines here: https://github.com/tensorflow/models/wiki/Submitting-a-pull-request

Thanks for submitting PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:official models that come under official repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants