MultiOperation handler refactoring #7025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Dec 20, 2024
| // Workflow was already started ... | ||
| if runningWorkflowLease != nil { | ||
| if err = mo.allowUpdateWorkflow(ctx, runningWorkflowLease, conflictPolicy); err != nil { | ||
| runningWorkflowLease.GetReleaseFn()(nil) // nil since nothing was modified |
There was a problem hiding this comment.
Moved the release here; and made allowUpdateWorkflow free of locking concerns.
alexshtin
approved these changes
Jan 8, 2025
| type ( | ||
| multiOp struct { | ||
| shardContext shard.Context | ||
| namespaceId string |
There was a problem hiding this comment.
Can you use namespace.ID instead of string here? I am using it everywhere where possible (where it doesn't make cycle dependencies). Even if you will need to convert it back and forth, it is better to have parameters and fields types more specific if possible.
I believe all paths have a test covering them. Let me run the tests again with code coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactored MultiOperation handler. Based on #7018.
Why?
Code hygiene.
How did you test it?
Existing tests. There are no (intended) behavior changes.
Potential risks
Documentation
Is hotfix candidate?