forked from facebookarchive/skybison
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite LOAD_GLOBAL _Unbound to LOAD_IMMEDIATE in builtins module #420
Draft
tekknolagi
wants to merge
1
commit into
trunk
Choose a base branch
from
mb-unbound-immediate
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
force-pushed
the
mb-unbound-immediate
branch
2 times, most recently
from
December 7, 2022 05:49
c33475e
to
1d219e9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hm. Looks like this is a big regression in the rewrite process since nqueens makes so many functions on the fly. Potential ways around this:
|
tekknolagi
force-pushed
the
mb-unbound-immediate
branch
2 times, most recently
from
March 22, 2023 22:57
58ff7ca
to
df60f02
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tekknolagi
force-pushed
the
mb-unbound-immediate
branch
from
March 23, 2023 13:30
ea54efe
to
7fdf49f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Bleh. Nqueens still has a 0.4% regression because rewriting takes longer. |
This should save some caches and be faster. Ideally we would do this in all Skybison-controlled modules but I don't think we have a good signal for that yet. Partially addresses #395; we still cannot use it as marker in dictionaries because it's still in the globals dict.
tekknolagi
force-pushed
the
mb-unbound-immediate
branch
from
May 14, 2023 02:36
7fdf49f
to
7f11ea6
Compare
{
"django_minimal_requests": {
"benchmark": "django_minimal_requests",
"cg_instructions before": 720237,
"cg_instructions now": 720349,
"cg_instructions ∆": "0.0%",
"interpreter_args": [],
"interpreter_name": "pyro",
"version before": "5215bf66fdf658b5a1758e9e18955ad42310e570",
"version now": "f10292b021f4e5ff072b466d771f0f0a378cbc15"
}
}
|
Summary
Benchmark detailsBase vs. New
CPython vs New
Base
New
CPython
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should save some caches and be faster. Ideally we would do this in
all Skybison-controlled modules but I don't think we have a good signal
for that yet.
Partially addresses #395