Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable documentation #606

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Variable documentation #606

merged 6 commits into from
Nov 6, 2024

Conversation

4t1l4
Copy link
Contributor

@4t1l4 4t1l4 commented Nov 4, 2024

Proposed Changes

  • Add variable documentation.

Closes #560

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

@4t1l4
Copy link
Contributor Author

4t1l4 commented Nov 4, 2024

Hi, this is still WIP, but I'd appreciate some early feedback.

The table in the main README is starting to get big, the horizontal scroll is not great. There are a few ways to go about this but I'm not sure which would be best so anything maintainers like is good to me.

I'm trying to keep the descriptions as they are in the argument_specs and only adding things where there's a choices argument or where there was no description, because I'm using ansible-doc to help me do this and it doesn't like it when an option or sub-option doesn't have one.

@4t1l4 4t1l4 changed the title Variable documenttion Variable documentation Nov 4, 2024
@timothystewart6
Copy link
Contributor

@4t1l4 wow! This looks great! I am sure everyone will appreciate this contribution!

@4t1l4 4t1l4 marked this pull request as ready for review November 5, 2024 10:50
@4t1l4
Copy link
Contributor Author

4t1l4 commented Nov 5, 2024

OK, ready for review now. Happy to adapt anything to make things easier to read or better structured. I'm very glad there's no MD linting in the hooks because that table would need a lot of tinkering with to fit the usual standards (I'd just stick some HTML instead if I had to).

@4t1l4
Copy link
Contributor Author

4t1l4 commented Nov 5, 2024

On a side note:

I noticed that some of the default values for 3rd party stuff (version tags) will get stale soon. I looked into those defaults in the roles and don't see any dependabot config there to manage it. I'm used to sticking custom regex with Renovate, but don't know if this is possible with dependabot. Happy to work on that on a separate PR so we get automated dep updates both in the code and the docs.

@timothystewart6
Copy link
Contributor

@4t1l4 thank you! That would be awesome if you could figure out the regex for the container tags that are specified in k3s-ansible/inventory/sample/group_vars/all.yml

@4t1l4
Copy link
Contributor Author

4t1l4 commented Nov 6, 2024

I created #608 for the dependency management stuff.

@timothystewart6 timothystewart6 merged commit 422621c into techno-tim:master Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Variables
2 participants