-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable documentation #606
Conversation
Hi, this is still WIP, but I'd appreciate some early feedback. The table in the main README is starting to get big, the horizontal scroll is not great. There are a few ways to go about this but I'm not sure which would be best so anything maintainers like is good to me. I'm trying to keep the descriptions as they are in the |
@4t1l4 wow! This looks great! I am sure everyone will appreciate this contribution! |
OK, ready for review now. Happy to adapt anything to make things easier to read or better structured. I'm very glad there's no MD linting in the hooks because that table would need a lot of tinkering with to fit the usual standards (I'd just stick some HTML instead if I had to). |
On a side note: I noticed that some of the default values for 3rd party stuff (version tags) will get stale soon. I looked into those defaults in the roles and don't see any dependabot config there to manage it. I'm used to sticking custom regex with Renovate, but don't know if this is possible with dependabot. Happy to work on that on a separate PR so we get automated dep updates both in the code and the docs. |
@4t1l4 thank you! That would be awesome if you could figure out the regex for the container tags that are specified in |
I created #608 for the dependency management stuff. |
Proposed Changes
Closes #560
Checklist
site.yml
playbookreset.yml
playbook