Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create API endpoints and tests for the entities #2

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Create API endpoints and tests for the entities #2

wants to merge 9 commits into from

Conversation

Fahdkassim
Copy link
Collaborator

@Fahdkassim Fahdkassim commented Oct 24, 2023 •
edited
Loading

  • Create the API endpoints for all the entities
  • Create tests for all the API endpoints
  • Implement user registration
  • Develop login/logout functionality
  • Add user signup fields validation using JOI

@Fahdkassim Fahdkassim self-assigned this Oct 24, 2023
hassaanp
hassaanp requested changes Oct 31, 2023
View reviewed changes
backend/modules/user/user.controller.ts Show resolved Hide resolved
backend/modules/user/user.controller.ts Outdated Show resolved Hide resolved
backend/modules/country/country.conrtoller.ts Outdated Show resolved Hide resolved
@Fahdkassim Fahdkassim requested a review from hassaanp November 1, 2023 08:03
hassaanp
hassaanp requested changes Nov 1, 2023
View reviewed changes
Copy link

@hassaanp hassaanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to validate all user inputs to ensure a robust and secure API

backend/modules/product/product.controller.ts Show resolved Hide resolved
backend/modules/product/product.controller.ts Show resolved Hide resolved
backend/modules/productImage/productImage.controller.ts Show resolved Hide resolved
backend/modules/productImage/productImage.controller.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassaanp hassaanp hassaanp requested changes

Assignees

@Fahdkassim Fahdkassim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fahdkassim @hassaanp