Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate: ODF TOOLKIT 0.12.0 #200

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

svanteschubert
Copy link
Contributor

@svanteschubert svanteschubert commented Dec 22, 2022

For the release candidate of ODF TOOLKIT 0.12.0 I have done so far the following:

  1. Adjusted dependencies of ODF 1.2 to ODF 1.3,
  2. Re-generated ODFDOM calling: mvn clean install -Ppedantic -Dcodegen
  3. Tested the Taglets for attributes/elements/data-types and fixed the following anomalies:

Unicode Local Change

When I adjusted our existing ODF templates for new documents in ODFDOM from ODF 1.2 to ODF 1.3:
https://github.com/tdf/odftoolkit/tree/master/odfdom/src/main/resources
by using LibreOffice 7.4.3 (configured to use strict ODF 1.3) to load/save the templates.
I had to adjust the version of the ODI (Image) and ODG (Graphic) file manually.
(All validated as strict ODF 1.3 with https://odfvalidator.org/ )
Suddently, the there are by default Unicode Locales for the Unicode Groups and the three assertions return values:
https://github.com/tdf/odftoolkit/blob/master/odfdom/src/test/java/org/odftoolkit/odfdom/doc/DocumentTest.java#L437 The test was adopted.

<manifest:key-derivation>

The element manifest:key-derivation has the choice of having either a single mandatory attribute value or multiple in ODF 1.3:

The code generator should better create two constructors one with a single and the other with three parameter, but it only provides the single paramater constructor, which occurred first. OdfPackage was adjusted for now, but code generator might better be improved.

SNAPSHOT Release

A SNAPSHOT released has been deployed to the Maven repository:
https://oss.sonatype.org/content/groups/public/org/odftoolkit/odfdom-java/0.12.0-SNAPSHOT/

Upcoming Website (BETA)

A beta website is available to review upcoming site changes:
https://svanteschubert.github.io/odftoolkit/index.html
The release date 22.12.2022 was/is very optimistic! :-)

It has been 10 years since we updated an ODF version. Is there something further to be adjusted (some parts - like the grammars - have been prior already added to the ODF Validator and Generator project).

NOTE: The integration of this PR will fix and close #26.

@svanteschubert
Copy link
Contributor Author

svanteschubert commented Dec 22, 2022

We have postponed the release just before FOSDEM so we have more time to review and test.

The following is already on my list:

  • generate both constructors for the Package layer and undo the OdfPackage adoption
  • in this branch comments in the pom.xml look bad, some automatic indent broke it (which tool?)
  • Test the odfvalidator.war in Tomcat - does the new ODF 1.3 mimetype work?
  • Is the new Mimetype part of ODF 1.3? Validator commit: a8ed669

@svanteschubert
Copy link
Contributor Author

There is one show stopper in the generation that I will have to fix after FOSDEM:
ODF has the attribue @text:value defined twice with different datatype:

  1. text:label/@text:value
    has datatype string
    https://docs.oasis-open.org/office/OpenDocument/v1.3/os/schemas/OpenDocument-v1.3-schema-rng.html#16807

  2. text:database-row-number"/@text:value
    hast datatype unsignedInteger
    https://docs.oasis-open.org/office/OpenDocument/v1.3/os/schemas/OpenDocument-v1.3-schema-rng.html#8733

This is currently ignored and not easy to add/fix in the current environment.

@dennisroczek
Copy link

after FOSDEM:
Which year? 😅

@svanteschubert
Copy link
Contributor Author

after FOSDEM:
Which year? 😅

Of course in the correct year 👻
(now stop the noise - sitting aside me in TDF devroom @FOSDEM and sending emails to public dev list🙈)

…text for attribute, which have different types depending on the element context
@svanteschubert svanteschubert marked this pull request as draft February 8, 2023 18:08
…he ODF RNG now have the type Boolean by default
…atatype boolean, but only 'true' and 'false' as explicit values. Added method to assume in this case the datatype Boolean
…different element context different types now nave this type supported (e.g. @dr3d:ligting-mode being boolean only in <dr3d:scene>) - the sharing attribute class inherting from Xerces AttrImpl will only save only a String
…differentiate equal named elements with different parents
@Boarschti42
Copy link

Hi, is it possible to deploy a new snapshot to the Repository since 0.11.0 is not useable in OSGI environment? next, when will this version be released?

@svanteschubert
Copy link
Contributor Author

Hi, is it possible to deploy a new snapshot to the Repository since 0.11.0 is not useable in OSGI environment? next, when will this version be released?

Sure, I have just uploaded a SNAPSHOT release from current master branch by 'mvn deploy' you need to use the version number 0.12.0-SNAPSHOT as given in https://github.com/tdf/odftoolkit/blob/master/pom.xml#L26
and it should be accessibly downloaded when SNAPSHOT is given by your pom.xml
You might download the JARs directly, e.g. for ODFDOM here: https://oss.sonatype.org/content/repositories/snapshots/org/odftoolkit/odfdom-java/0.12.0-SNAPSHOT/
Could you please test it if this works for you? I am not able to test any OSGI environment.

Hopefully this is helping you, Karsten!

Good luck with it!
Svante

@mistmist mistmist modified the milestones: 0.12.0, 0.13.0 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding ODF 1.3 support to the ODF Toolkit
4 participants