Add additional tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taminob
force-pushed
the
feature/add-more-tests
branch
2 times, most recently
from
e1e48e2 to
6ac40c6
Compare
In order to test the cmake configuration of this repository, add a test CMake project which uses this library as a dependency. This project will then be built with the different possible configurations to ensure they work as expected.
These tests are expected to fail because they try to use the shared library when only the static version is installed and the other way around.
taminob
force-pushed
the
feature/add-more-tests
branch
3 times, most recently
from
5fefccc to
bfa715c
Compare
For this, an additional job was added to the build-and-test workflow.
Previously, the fmt::fmt target was not imported when this library was imported via cmake. Additionally, the necessary compile definition is set in projects using it as a dependency via the target-specific target_compile_definitions().
CMake 3.30 removed the FindBoost module in favor of BoostConfig.cmake which is included in boost v1.70 or newer. This new mechanism can be used by simply adding "CONFIG" to the find_package call. Alternatively, the minimum CMake version of 3.30 can be specified to avoid the warning and explicitly use the backwards-compatible fallback mechanism implemented in this CMake version. Since many systems do not have CMake 3.30 yet, this commit upgrades boost to v1.70 which is reasonably seasoned and should be available in most cases and uses the new mechanism.
Additionally, make line width in cmake-format workflow explicit since for the linting it needs to be increased. This is because some lines cannot be formatted with only 80 characters per line. Thus, the character limit per line is increased to 90 for now in the linting job.
taminob
force-pushed
the
feature/add-more-tests
branch
from
96f9a49 to
4cf1294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake_testsfor testing the installation in combination withfind_packagein cmake projects