Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Do not extract class names from functions #15566

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Jan 7, 2025

This PR prevents the migration of utilities detected in function names, e.g.: the use of shadow inside filter: 'drop-shadow(…)'.

Test plan

Have content like this in a project you're migrating using the upgrade tool:

{
  filter: 'drop-shadow(0 0 0.5rem #000)'
}

This was verified by adding unit tests to the specific codemods and adding an integration test.

@philipp-spiess philipp-spiess force-pushed the fix/dont-migrate-candidates-used-as-fns branch from 517425f to d4e5a86 Compare January 7, 2025 12:48
@philipp-spiess philipp-spiess changed the title Upgrade: Do not extract class names from functions (e.g. shadow in … Upgrade: Do not extract class names from functions Jan 7, 2025
@philipp-spiess philipp-spiess force-pushed the fix/dont-migrate-candidates-used-as-fns branch from d4e5a86 to 2c21cb8 Compare January 7, 2025 12:50
@philipp-spiess philipp-spiess marked this pull request as ready for review January 7, 2025 12:51
@philipp-spiess philipp-spiess requested a review from a team as a code owner January 7, 2025 12:51
@philipp-spiess philipp-spiess force-pushed the fix/dont-migrate-candidates-used-as-fns branch from 2c21cb8 to b28e9bb Compare January 7, 2025 14:25
@philipp-spiess philipp-spiess force-pushed the fix/dont-migrate-candidates-used-as-fns branch from b28e9bb to 19b7123 Compare January 7, 2025 14:26
@philipp-spiess philipp-spiess merged commit d4f693f into next Jan 7, 2025
5 checks passed
@philipp-spiess philipp-spiess deleted the fix/dont-migrate-candidates-used-as-fns branch January 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants