-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @tailwindcss/browser
package
#15558
Conversation
2e4fa19
to
0eb47a7
Compare
0eb47a7
to
8cebf4f
Compare
@RobinMalfait Is there anything special I need to do to make sure publishing will work? |
@tailwindcss/cdn
package@tailwindcss/browser
package
Nope should be good! We publish via You can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty impressive how simple the code for this is. 👏
Co-authored-by: Philipp Spiess <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -39,7 +39,7 @@ | |||
"dev": "turbo dev --filter=!./playgrounds/*", | |||
"test": "cargo test && vitest run --hideSkippedTests", | |||
"test:integrations": "vitest --root=./integrations", | |||
"test:ui": "pnpm run --filter=tailwindcss test:ui", | |||
"test:ui": "pnpm run --filter=tailwindcss test:ui && pnpm run --filter=@tailwindcss/browser test:ui", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can/should we merge these? I think we can use --filter
twice 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do that it does some super super weird stuff to the console output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it, that is … interesting 😂
Co-authored-by: Philipp Spiess <[email protected]>
Co-authored-by: Philipp Spiess <[email protected]>
We're going to publish the CDN / browser build of v4 as an npm package so it can be loaded from things like unpkg. This sets up the package for that. The CDN is still intended only for development use. Please do not use it in production.
Note: like the v3 CDN, since it reacts to changes in the DOM, some things like transitions can break if the transition relies on the class being defined before being added to the DOM for correct behavior.