Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove process.env.VERSION check #14531

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Remove process.env.VERSION check #14531

merged 1 commit into from
Sep 27, 2024

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Sep 26, 2024 •
edited
Loading

Fixes #14523

@thecrypticace
Copy link
Contributor Author

@philipp-spiess I couldn't find any references to process.env.VERSION anywhere else but I swear it was being used at one point. Was that a leftover from our Standalone CLI work? Tests seem to pass so maybe we ended up not actually needing it?

@philipp-spiess philipp-spiess marked this pull request as ready for review September 27, 2024 08:45
philipp-spiess
philipp-spiess approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thecrypticace Yeah this looks like it sneaked in by accident. The only place where we need to patch the version is for the CLI. e.g. grep for __tw_version. VERSION is used nowhere in the codebase.

@thecrypticace thecrypticace merged commit d3440c1 into next Sep 27, 2024
3 checks passed
@thecrypticace thecrypticace deleted the fix/v4-remove-process-env-version branch September 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix compiler in non-Node.js environments?
2 participants
@thecrypticace @philipp-spiess