CSS codemod: ensure we don't lose selectors #14518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a CSS rule with a selector that contains multiple selectors lost everything but the last selector.
While testing the
npx @tailwindcss/upgrade
codemods on real world projects, I noticed that we lost one of the selectors in thedocker/docs
repository.This PR fixes the issue by not overriding the
node.selector
internally with the last selector we handled. Instead, we let the selector parser handle it entirely.