[6.1] Fix build option for Synchronization and Distributed #78496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These utilities are called from MandatorPerformanceOptimizations which can run on serialized non-ossa functions. Add a bailout to handle this case.
|
@swift-ci test |
meg-gupta
changed the title
Since Synchronization is in non-ossa, it cannot be imported into an ossa module. We have support for recompilation of the .swiftinterface with -enable-ossa-modules under implicit modules. However, recompilation of modules in the resource dir is disabled unless serialization status is serialization::Status::SDKMismatch in discoverUpToDateCompiledModuleForInterface. Removing the -enable-ossa-module flag in this test to avoid module loading failure
|
@swift-ci test |
tbkka
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: #77314 incorrectly named the parameter name which resulted in the -enable-ossa-modules being present in the swift interfaces of Synchronization and Distributed. This PR fixes the cmake function parameter name while querying for IMPORTS_NON_OSSA by using the right prefix used in cmake_parse_arguments
Scope: Removes -enable-ossa-modules from swiftinterfaces of Synchronization and Distributed
Original PRs: #78460
Issue: rdar://138407068
Risk: Low
Testing: swift ci testing and manually verified the absence of the flag in the swiftinterfaces of Synchronization and Distributed
Reviewed by: @tshortli