[6.1][CSApply] Sendable-to-Any: Add support for l-value to l-value and inout unsafe casts #78492
+198
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`coerceToType` can to handle l-value -> inout correctly and report better information if coercion fails. (cherry picked from commit c225db4)
…econcurrency context (cherry picked from commit b7a7839)
… equality If type equality check fails we need to check whether the types are the same with deep equality restriction since `any Sendable` to `Any` conversion is now supported in generic argument positions of @preconcurrency declarations. i.e. referencing a member on `[any Sendable]` if member declared in an extension that expects `Element` to be equal to `Any`. (cherry picked from commit 79f6b07)
|
@swift-ci please test |
hborla
approved these changes
Jan 8, 2025
`any Sendable` -> `Any` in generic argument positions should be supported for l-value and inout types as well otherwise it won't be possible to call setters and mutating methods. (cherry picked from commit 0a0a34c)
xedin
force-pushed
the
Sendable-to-Any-for-lvalues-6.1
branch
from
43e95a7 to
4778032
Compare
|
@swift-ci please test |
|
SILGen output is slightly different in 6.1 and has type annotations for casts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #78487
Explanation:
Extends functionality of
any Sendable->Anyconversion ingeneric argument positions to support subscripts and mutating accesses.
This means that we cannot reply on simple type equality in some
cases i.e. when applying base to
selfparameter. If type equalitycheck fails we need to check whether the types are the same with
deep equality restriction since
any SendabletoAnyconversionis now supported in generic argument positions of
@preconcurrencydeclarations. i.e. referencing a member on
[any Sendable]if memberdeclared in an extension that expects
Elementto be equal toAny.Main Branch PR: [CSApply] Sendable-to-Any: Add support for l-value to l-value and inout unsafe casts #78487
Resolves: rdar://140300022
Risk: Low (Extends functionality of the previous PR - [6.1][TypeChecker/SILGen] Allow
any Sendableto matchAnywhile matching generic arguments #78272 to support subscripts and mutating accesses).Reviewed By: @hborla
Testing: Added new tests to the concurrency, SILGen, and interpreter test suites.