Fix LifetimeDependenceScopeFixup to avoid rewriting mark_dependence. #78482
+67
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pass rewrites mark_depenendence to ignore "useless" borrow scopes. It was also accidentally rewriting a dependence on a loaded value, which may redirect the dependence to the access scope used to load that value. That access scope may be narrower than the lifetime of the loaded value which could result in invalid SIL. Do not rewrite this mark_dependence: %access = begin_access [read] [unknown] %base %load = load [trivial] %access end_access %access %adr = pointer_to_address %md = mark_dependence [unresolved] %adr on %load Fixes rdar://142424000 (Swift compiler crashes with Assertion failed (isa<UnreachableInst>(block->getTerminator())))
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci benchmark |
Recognize dependence on the address of a trivial 'var' as an "access" dependence instead of an "unknown" dependence. This allows the mark_dependence to be resolved as "[nonescaping]".
atrick
force-pushed
the
fix-markdep-load
branch
from
2b2a9a4 to
195ca7c
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci test |
|
@swift-ci test source compatibility |
1 similar comment
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass rewrites mark_depenendence to ignore "useless" borrow scopes. It was also accidentally rewriting a dependence on a loaded value, which may redirect the dependence to the access scope used to load that value. That access scope may be narrower than the lifetime of the loaded value which could result in invalid SIL. Do not rewrite this mark_dependence:
%access = begin_access [read] [unknown] %base
%load = load [trivial] %access
end_access %access
%adr = pointer_to_address
%md = mark_dependence [unresolved] %adr on %load
Fixes rdar://142424000 (Swift compiler crashes with Assertion failed (isa(block->getTerminator())))