[sil] Add flexibility to SILPrinter to allow for full SIL types to printed out in the debugger and programatically without touching the global flag. #78480
+96
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
eeckstein,
jckarter and
DougGregor
as code owners
|
@swift-ci test |
eeckstein
approved these changes
Jan 8, 2025
gottesmm
force-pushed
the
pr-2e966caa607714d3609428172c32939fb183ff49
branch
from
de5423a to
8bd60da
Compare
|
@swift-ci smoke test |
…f boolean flags. This will allow for more control of how SIL is printed in logging messages and also will make it easier to feed flags through SILFunction::dump and friends.
…o set the global flag. This is useful if one wants to dump out state in the debugger or programatically dump out SIL with all of the types without changing the behavior in the rest of the compiler. My intention is to use this to emit full types in a little bit of the logging in SendNonSendable where seeing the full type speeds up debugging in the context of debugging user code and where in truth, I will never ever want to suppress types and will not use this to create test cases. It is just for quick scanning.
gottesmm
force-pushed
the
pr-2e966caa607714d3609428172c32939fb183ff49
branch
from
8bd60da to
c83c4cd
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds flexibility to the SIL printer API such that users can emit full SIL types without touching the global flag. This is implemented by changing SILPrinterContext to take an OptionSet instead of boolean flags and adding a flag to SILPrinterContext that forces the behavior. The default behavior is left alone and is controlled via the global flag.
By doing this, without changing any normal path behavior, we allow for: