stdlib,Runtimes: begin preparing for a static stdlib on Windows #78476
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
etcwilde and
DougGregor
and removed request for
a team
|
@swift-ci please test |
etcwilde
reviewed
Jan 7, 2025
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
etcwilde
approved these changes
Jan 8, 2025
|
@swift-ci please test Linux platform |
|
@swift-ci please smoke test |
When building the standard library statically on Windows, we should not use any __declspec(dllimport) or __declspec(dllexport) on the runtime functions or data. Furthermore, we should internalise all of the standard library functions so that they are not re-exported if used to build a shared library. The code generation changes required for this are easier to identify once a static SDK is available for Windows.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the standard library statically on Windows, we should not use any
__declspec(dllimport)or__declspec(dllexport)on the runtime functions or data. Furthermore, we should internalise all of the standard library functions so that they are not re-exported if used to build a shared library. The code generation changes required for this are easier to identify once a static SDK is available for Windows.