Sema: Fix local property wrappers on constructor #78470
Merged
+54
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
reviewed
Jan 7, 2025
| @@ -1632,6 +1632,13 @@ class Solution { | |||
| /// A map from argument expressions to their applied property wrapper expressions. | |||
| llvm::DenseMap<ASTNode, SmallVector<AppliedPropertyWrapper, 2>> appliedPropertyWrappers; | |||
|
|
|||
| ArrayRef<AppliedPropertyWrapper> getAppliedPropertyWrappers(ASTNode anchor) { | |||
| auto found = appliedPropertyWrappers.find(anchor); | |||
There was a problem hiding this comment.
IMO we really ought to be keying this with the callee locator itself, not just the anchor. For e.g key paths with subscript components you can have different callee locators that share the same anchor (although we don't currently support external property wrappers for subscripts)
There was a problem hiding this comment.
Yeah, we do know that argument/parameter pair this property wrapper corresponds to, should be able to use full locator while applying and re-create it while coercing arguments...
Fixes rdar://problem/142443421.
slavapestov
force-pushed
the
fix-rdar141961300
branch
from
ec82065 to
c170443
Compare
|
@swift-ci Please smoke test |
|
For posterity: we discussed this offline and decided to take this fix tentatively until we can find a better setup by changing how property wrappers are anchored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/141961300.