Sema: Don't remove nonisolated attribute when we diagnose it as invalid on 'lazy' #78468
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fix-141967932
branch
from
ba497c2 to
ec387fa
Compare
|
@swift-ci Please smoke test |
ktoso
approved these changes
Jan 7, 2025
xedin
approved these changes
Jan 8, 2025
…id on 'lazy' Otherwise, we'll in turn complain if the nonisolated lazy property was @objc. This is also invalid, but the goal here is to avoid the source break until -swift-version 6. Fixes rdar://141967932.
slavapestov
force-pushed
the
fix-141967932
branch
from
ec387fa to
e663ad0
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://141967932.