This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Implement 'getCodepoints' method on the generator result Object #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sunflowerdeath - I'm maintaining a small cli utility using
webfonts-generatoras core - one of the functionalities it implements is optionally rendering ajsonfile containing all codepoints mapped to the icon names.The way I'm currently obtaining that is by parsing the output CSS and re-mapping it to a JS object, though it's quite a hacky way and it means it will not parse correctly when passing in a custom CSS template, as it's currently based on CSS rules regex.
Exposing a method on the
resultsobject that returns the raw map of codepoints would make this process a lot cleaner and may also be handy to other people wanting to do something different with the library.The PR includes a test and addition to readme, it should be minimum amount of work to get it out - let me know if you think it's something we can get merged and published or whether I can contribute another way.
Thanks!