Added blacklisting feature #9
Conversation
wachterjohannes
force-pushed
the
feature/blacklisting
branch
15 times, most recently
from
27784d2 to
1d6fa6c
Compare
| $entityManager->flush(); | ||
|
|
||
| $communityManager = $this->getCommunityManager($blacklistUser->getWebspaceKey()); | ||
| $communityManager->sendEmails(Configuration::TYPE_REGISTRATION, $blacklistUser->getUser()); |
There was a problem hiding this comment.
should we maybe create here an own config type (TYPE_BLACKLIST_CONFIRM) which use the registration config as default when not set specific. or do you think it will be always the same email template?
There was a problem hiding this comment.
If we would send the emails by an listener on the BlacklistUser Entity it would also work when the user is denied or confirmed in an admin interface.
There was a problem hiding this comment.
the admin list can only link to this controller. because we cannot confirm a user from the admin-kernel
| public function putAction($id, Request $request) | ||
| { | ||
| $repository = $this->get('sulu_community.blacklisting.item_repository'); | ||
| $entityManager = $this->get('doctrine.orm.entity_manager'); |
There was a problem hiding this comment.
same would move it to a service
wachterjohannes
force-pushed
the
feature/blacklisting
branch
2 times, most recently
from
bdc2e57 to
0728397
Compare
|
@alexander-schranz this should be good now |
wachterjohannes
force-pushed
the
feature/blacklisting
branch
2 times, most recently
from
3943e41 to
e91e9bb
Compare
|
@wachterjohannes could we hide the checkbox on not created entites and sometimes when you add fast some items in the list the entities are not saved and stay as input field.
|
|
@wachterjohannes my test with |
wachterjohannes
force-pushed
the
feature/blacklisting
branch
from
e91e9bb to
d56c56e
Compare
wachterjohannes
force-pushed
the
feature/blacklisting
branch
from
d56c56e to
bcf74f9
Compare
wachterjohannes
force-pushed
the
feature/blacklisting
branch
from
75e04cc to
65d6952
Compare
|
massiveart/husky#663 i have created an husky issue for you thought about the datagrid. |
Fix check if template exists to send an email
What's in this PR?
This PR adds the functionality to manage a blacklist in the sulu-admin. Each entry consists of a pattern (like *@sulu.io) and one of the following types:
block: an email which matches the pattern cannot be used to register a user.request: an email which matches the pattern have to be confirmed by an administrator (will get an email) before the user will get the double-opt emailWhy?
This should enhance the administrator to manage a blacklist of "spaming" email hosters and block specific email addresses to be reused after deleting a user.