Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced the CSS of NewsShelter Section #630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Pranjal6955
Copy link

@Pranjal6955 Pranjal6955 commented Jan 3, 2025

Description

This pull request introduces design enhancements to the NewsShelter section, focusing on the email input field and the subscribe button. These updates aim to deliver a more polished and user-friendly interface, aligned with modern design practices, while improving the overall user experience.


Changes Made

Email Input Field Enhancements

  • Added a rounded border for a softer and more appealing look.
  • Implemented a subtle glow effect on focus to enhance interactivity and draw user attention.
  • Included the required attribute for improved form validation.

Subscribe Button Enhancements

  • Applied a hover effect with a smooth color transition to provide visual feedback.
  • Adjusted padding for better alignment and visual harmony with the input field.

Scoped Styles

  • Scoped all new styles locally within <style> tags to ensure they do not interfere with global styles.

Impact

Enhanced User Experience

  • A visually appealing and interactive interface that encourages user engagement.

Improved Accessibility

  • Refined designs ensure usability across various screen sizes and enhance responsiveness.

Better Maintainability

  • Scoped styles make the design changes easier to manage without affecting global CSS.

Screenshots

  1. Before Enhancements:
    IMG1

2 After Enhancements:
IMG2

Enhanced CSS of NewsShelter section
Updated structure of NewsShelter Section
@Pranjal6955
Copy link
Author

@quozl Please Review it

@quozl
Copy link
Contributor

quozl commented Jan 3, 2025

Backward link to old pull request; #629

You haven't fixed the commit messages as already mentioned by @vidipsingh.

You have changed css/airspace.css against our frequent advice not to do so as it makes it harder for us to upgrade the theme using upstream source code.

Looks like you haven't been reading other pull requests, commit history or our community documentation. i.e. you don't seem to be taking care, and you're placing the burden on reviewers.

@chimosky please review. 😁

@quozl
Copy link
Contributor

quozl commented Jan 4, 2025

I don't know why you keep closing pull requests. None of the changes we've requested would require a new pull request.

@Pranjal6955 Pranjal6955 reopened this Jan 5, 2025
@Pranjal6955
Copy link
Author

@quozl Sorry for the ping. I am new to open source and am struggling to fully understand the contribution process. Could you please let me know what I did wrong and how I can fix it?

@quozl
Copy link
Contributor

quozl commented Jan 5, 2025

I'm happy to tell you what you did wrong, but won't take the time to tell you how to fix it, because

  • it would take a shorter time to fix it myself, diluting authorship, and;
  • it isn't clear what you intended anyway.

We've given feedback in this pull request and your previous one. I don't think we should repost that feedback, you should scroll up, read it, and if there's something you don't understand (about what you did wrong, not about how to fix it) please ask.

If you don't know how to fix it, there's Google, our Matrix channel, and documentation for Git, GitHub, and everything else. Other pull requests and issues in the repository may also help you, both open and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants