Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py file #4

Closed
wants to merge 1 commit into from
Closed

Add setup.py file #4

wants to merge 1 commit into from

Conversation

nswarup14
Copy link

Fixes #2
Thanks

Copy link

@rhl-bthr rhl-bthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments

setup.py Outdated
from sugar3.activity import bundlebuilder

if __name__ == "__main__":
bundlebuilder.start()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing newline at the end of the file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nswarup14
Copy link
Author

@pro-panda
Added the newline
Please review, thanks

@quozl
Copy link

quozl commented Jan 21, 2019

For interest;

% python setup.py dist_xo
WARNING:root:Activity bundle /tmp/riverhex-activity does not specify a license
WARNING:root:Missing po/ dir, cannot build_locale

I'm not sure if the license covers the old 32-bit binary bin/riverhexactivity.exe.

@nswarup14
Copy link
Author

@quozl
When I run sudo python setup.py dist_xo, I do not get any warnings.
I did not understand what you pointed about the old 32-bit binary executable and its license.

Please advise, Thanks

@quozl
Copy link

quozl commented Jan 21, 2019

sudo ... do not get any warnings

Do not use sudo to run dist_xo; there's no need for it. You will not get warnings if you are using an old version of the Sugar Toolkit. What version are you using?

I did not understand what you pointed about the old 32-bit binary executable and its license.

Happy to explain.

You added a file. This enabled tests that were not enabled before. As a result of the tests, I saw there is a 32-bit binary file. The path is as described. To comply with license (see LICENSE, and activity.py), we must be able to produce the source. I can't find the source in the repository. This makes the bundle produced by dist_xo impossible to distribute by Sugar Labs, due to our nature and governance. That it is 32-bit makes the activity architecture specific. It may also make the activity not work on 64-bit architectures and different CPUs such as ARM. I've not tested the activity; have you? These are ancillary problems; but far greater priority than adding a setup.py file. I'd prefer to see a complete solution before merging.

@nswarup14
Copy link
Author

nswarup14 commented Jan 22, 2019

Do not use sudo to run dist_xo; there's no need for it.

@quozl , I tried running without sudo, but it showed me a permission denied message. Does that mean something is incorrect on my system.
I am working on a Lenovo, 64-bit thinkpad with Ubuntu 18.04 and Sugar v0.112 (I think the latest version it self).

It may also make the activity not work on 64-bit architectures and different CPUs such as ARM

The activity is architecture specific, because in the activity.py, its actually mentioned that the activity wont run on ARM architecture. And no, I haven't been able to test on other architectures because I lack them.

I can't find the source in the repository

You're right, there is no source code and hence by the LICENSE cannot be distributed.

Is there anything I could do to help with this?
Thank you!

@quozl
Copy link

quozl commented Jan 22, 2019

is there anything I could do to help with this?

Possibly. See if you can move a step closer after this research;

  • on our mailing lists there is almost no mention of RiverHex, one exception is a test report by Tony Anderson on 29th December 2015,
  • according to http://activities.sugarlabs.org/en-US/sugar/addon/4325 the maintainer was @llaske in 2010, and the activity is written in Mono, see http://wiki.sugarlabs.org/go/Mono for technical detail,
  • there's no repository that I've found on GitHub or git.sugarlabs.org that contains the source code,
  • there's nothing on a Google Search that seems to fit,
  • the bundle file riverhex-2.xo available from activities.sugarlabs.org has shareable library files in bin/ that are critical, but they have been lost in the transition from bundle to GitHub, by @cristian99garcia,

Perhaps next step is just to ask questions of appropriate people; @llaske, have you the source code?

but it showed me a permission denied message

Mine does not show that message. Is there any further detail, like a file name? You might try strace -e open prefix to the command to get a log of all files opened and result of open attempt. Or check all the files in the repository have you as owner rather than root.

0.112 (I think the latest version it self)

Thanks. Yes, 0.112 is the latest version available from Ubuntu, but we have commits to Sugar and the Toolkit since. The messages I see are probably related to changes since 0.112.

@llaske
Copy link

llaske commented Jan 23, 2019

I'm the author of the activity but I must confess I've stopped to maintain it for a long time.
I've uploaded all source code I've found on my laptop here: https://github.com/llaske/RiverHexActivity
Hope it will help.

@quozl
Copy link

quozl commented Jan 23, 2019

Thanks @llaske!

@quozl
Copy link

quozl commented Jan 28, 2019

Closing pull request. Fix #5 first, thanks.

@quozl quozl closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants