-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix line endings #26
base: main
Are you sure you want to change the base?
Conversation
… element is necessary for correct work
Can you provide jsfiddle/jsbin with example of what exactly didn't work for you? Not sure what's your exact problem is, but release https://github.com/sudodoki/copy-to-clipboard/releases/tag/1.1.1 did work with newlines correctly (although there was an issue with content that needed escaping - see some closed issues for more info). |
Yea you can check jsfiddle |
Will try to get to this on weekend, need to figure out if there are other workarounds and test usual test cases. |
Thanks for bringing this up. |
There are no problems, can help at any time with any questions |
@sudodoki if this PR passes the tests, we can merge it, make couple fixes and release new patch (3.0.5). With |
@shvaikalesh need to verify we are not going to run into issues with multiline text and final newline in chrome/safari vs firefox in textarea as during writing e2e test it turned out there are inconsistencies (might be only with pasting, and not setting value through js). Don't think I will have time to do that now, although this change might be desirable. |
hello old fix really has a big problem if the copy 40000 rows. I found a solution which is suitable for all scenarios, this method work in all cases for themselves now. I'm sorry for error. |
|
yea this is sucks, can we use method depending on the situation? |
Is there any progress on this? This problem is biting me in the ass too. I'm willing to help out, if needed. |
Bump; any updates? |
@andmetoo @SEAPUNK still didn't have enough time to look into this re #26 (comment). Might consider depending on |
@SEAPUNK U can use directly from my fork |
I am, but I prefer that I install from releases. |
🔨The ends of lines don't work correctly in the created layer,
textarea
element is necessary for correct work.