feat: add f32 and f64 types
#40
Merged
+373
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshaaban01
changed the title
f32 and f64 types and testsf32 and f64 types
dshaaban01
force-pushed
the
dalia/types/floats
branch
3 times, most recently
from
fae0b91 to
810f6bd
Compare
|
Note: 2 missing test files, have weird failures I will analyze later today. Edit: Done |
ingomueller-net
approved these changes
Jan 6, 2025
dshaaban01
force-pushed
the
dalia/types/floats
branch
from
a678981 to
f04f5e4
Compare
|
(I'll let you rebase the remaining PRs before taking a look. They'll have conflicts like this one anyway; hopefully, I can merge most of the right away after the rebase.) |
|
Rebase floats done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
f32andf64types +f32andf64attribute types.Added tests for
f32andf64types but NOT for attributes. Waiting on this PR to be merged and then will add those tests to project.mlir test file (similarly to integer types)! @ingomueller-net