Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add decimal literal to string method #100

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

EpsilonPrime
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.66%. Comparing base (e403121) to head (b0dd5b4).

Files with missing lines Patch % Lines
expr/literals.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   62.48%   62.66%   +0.17%     
==========================================
  Files          44       44              
  Lines       10148    10170      +22     
==========================================
+ Hits         6341     6373      +32     
+ Misses       3523     3513      -10     
  Partials      284      284              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

expr/literals.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought I had was whether we should add this string to decimal as a literal construction method. I believe we have a builder or api for literal construction, right?

@EpsilonPrime
Copy link
Member Author

One thought I had was whether we should add this string to decimal as a literal construction method. I believe we have a builder or api for literal construction, right?

Yes, that's useful. There is NewDecimalFromString (literal/utils.go) which utilizes this method.

@EpsilonPrime EpsilonPrime merged commit be0b09b into substrait-io:main Jan 9, 2025
4 of 6 checks passed
@EpsilonPrime EpsilonPrime deleted the decimalliteral branch January 9, 2025 19:24
EpsilonPrime added a commit that referenced this pull request Jan 15, 2025
Adds the functionality QueryString() functionality requested in #100 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants