-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add decimal literal to string method #100
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 62.48% 62.66% +0.17%
==========================================
Files 44 44
Lines 10148 10170 +22
==========================================
+ Hits 6341 6373 +32
+ Misses 3523 3513 -10
Partials 284 284 ☔ View full report in Codecov by Sentry. |
1fe9a4a
to
8caab11
Compare
27affcd
to
b0dd5b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought I had was whether we should add this string to decimal as a literal construction method. I believe we have a builder or api for literal construction, right?
e6ce663
to
32d10b6
Compare
Yes, that's useful. There is NewDecimalFromString (literal/utils.go) which utilizes this method. |
Adds the functionality QueryString() functionality requested in #100 .
No description provided.