[SDFAB-1178] Allow and write in/e-gress counter separately #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierventre
reviewed
May 4, 2022
src/main/java/org/stratumproject/fabric/tna/behaviour/upf/FabricUpfProgrammable.java
Outdated
Show resolved
Hide resolved
src/main/java/org/stratumproject/fabric/tna/behaviour/upf/FabricUpfProgrammable.java
Show resolved
Hide resolved
src/main/java/org/stratumproject/fabric/tna/behaviour/upf/FabricUpfProgrammable.java
Outdated
Show resolved
Hide resolved
src/main/java/org/stratumproject/fabric/tna/behaviour/upf/FabricUpfProgrammable.java
Outdated
Show resolved
Hide resolved
daniele-moro
changed the title
daniele-moro
changed the title
daniele-moro
commented
May 9, 2022
| @@ -559,6 +562,39 @@ private Collection<UpfEntity> getUpfTerminationsDownlink() throws UpfProgrammabl | |||
| return upfTerminations; | |||
| } | |||
|
|
|||
| private void applyUpfCounter(UpfCounter upfCounter) throws UpfProgrammableException { | |||
There was a problem hiding this comment.
This needs to be updated when we'll have the counter subsystem in ONOS
pierventre
approved these changes
May 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
============================================
+ Coverage 69.92% 70.47% +0.54%
- Complexity 739 768 +29
============================================
Files 63 63
Lines 4802 4844 +42
Branches 530 538 +8
============================================
+ Hits 3358 3414 +56
+ Misses 1165 1145 -20
- Partials 279 285 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the changes in the
mod_cntrbranch.