Release: Patch 8.5.1 #30334
Open
Release: Patch 8.5.1 #30334
+62
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
25 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
docs/versions/next.json
Outdated
| @@ -1 +1 @@ | |||
| {"version":"8.5.0-beta.11","info":{"plain":"- CLI: Update a11y-test comment with experimental caveat - [#30258](https://github.com/storybookjs/storybook/pull/30258), thanks @shilman!\n- Manager API: Fix infinite render-loop caused by `useSharedState` - [#30259](https://github.com/storybookjs/storybook/pull/30259), thanks @JReinhold!"}} | |||
| {"version":"8.6.0-alpha.0","info":{"plain":""}} | |||
There was a problem hiding this comment.
logic: The version in next.json is incorrect - it shows 8.6.0-alpha.0 but this PR is for patch release 8.5.1. This needs to be fixed before merging.
docs/versions/next.json
Outdated
| @@ -1 +1 @@ | |||
| {"version":"8.5.0-beta.11","info":{"plain":"- CLI: Update a11y-test comment with experimental caveat - [#30258](https://github.com/storybookjs/storybook/pull/30258), thanks @shilman!\n- Manager API: Fix infinite render-loop caused by `useSharedState` - [#30259](https://github.com/storybookjs/storybook/pull/30259), thanks @JReinhold!"}} | |||
| {"version":"8.6.0-alpha.0","info":{"plain":""}} | |||
There was a problem hiding this comment.
logic: The info.plain field is empty in next.json but should contain the changelog entry for 8.5.1 that's shown in the PR description.
storybook-bot
force-pushed
the
version-patch-from-8.5.0
branch
2 times, most recently
from
4aee94d to
002cd3d
Compare
Addon Test: Replace `interaction test` -> `component test` (cherry picked from commit edbaea1)
…-in-manager-import Manager: Escape single quotes in dynamic import paths in wrapManagerEntries function (cherry picked from commit 28e3c9e)
…upport RNW-Vite: Support requires for images/fonts (cherry picked from commit 586641e)
storybook-bot
force-pushed
the
version-patch-from-8.5.0
branch
from
002cd3d to
6aa959d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0to8.5.1.Once this pull request is merged, it will trigger a new release of version
8.5.1.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:interaction test->component test#30333🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x 4d2989d48746f04220bddf27d2ceec9f966343bdIf you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.1
interaction test->component test- #30333, thanks @kylegach!