-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add "features" question & auto-install test addon & improve test-addon compatibility #30202
Merged
+2,217
−570
Merged
Changes from 1 commit
Commits
Show all changes
216 commits
Select commit
Hold shift + click to select a range
bde2134
ink in core and esm in create-storybook
ndelangen 7e4592d
ink in init
ndelangen 9f88950
Merge branch 'next' into norbert/cli-with-ink
ndelangen 59d7c63
fix
ndelangen 6462b7b
keep other package dist bundling unchanged
ndelangen 3a19d00
fix
ndelangen 71df9d9
Merge branch 'next' into norbert/cli-with-ink
ndelangen b5f7b2e
support ink types
ndelangen 25d7e76
use esm of CLI
ndelangen 760ce6d
fixes for check to support for moduleresolution=bundler
ndelangen c44aca3
add cjs
ndelangen 321de92
undo shim change in prepare script
ndelangen 9683316
Merge branch 'next' into norbert/cli-with-ink
ndelangen 20844fc
disable parallelism as it's not letting me see the issue, and i canno…
ndelangen 57bc122
rendering with ink embedded in vite
ndelangen 0eec9b0
add `node` condition for chalk
ndelangen e84572d
fix
ndelangen 0f42062
unit test pass?
ndelangen b843a68
Discard changes to .circleci/config.yml
ndelangen 199b5bf
fix linting
ndelangen 5da8301
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 0fccec9
fix linting
ndelangen fb51e3b
add first demo story of an ink component
ndelangen 1a5fe81
Discard changes to code/lib/cli-storybook/test/default/cli.test.cjs
ndelangen 7440621
cleanup
ndelangen 21c04b7
Merge branch 'next' into norbert/cli-with-ink
ndelangen 9541d3e
cleanup
ndelangen 1e75423
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 5ff6089
typings
ndelangen 90f12d7
update the target environment so we do not need TLA plugin, which see…
ndelangen 69d64f8
cleanup
ndelangen a876450
fix types
ndelangen 94843bf
patch away the top-level-away and devtools from ink to fix https://cl…
ndelangen b79205f
Revert "patch away the top-level-away and devtools from ink to fix ht…
ndelangen 49f2c44
fix dev
ndelangen 35505ec
fix dev actually
ndelangen f02c1a7
centered
ndelangen 211318f
fix firefox Intl.Segmenter in chromatic
ndelangen 580cf60
try to fix
ndelangen 234c8da
alt solution
ndelangen 6555742
add debug
ndelangen fe1e4c7
debug
ndelangen 098a52e
Merge changes from POC
ghengeveld 02cffc8
conditional ink stories, do not add when running vitest
ndelangen c97f554
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 2cbdd8e
fix windows compilation problem with pathing
ndelangen e821aae
remove story I added fro debugging purposes
ndelangen 660aa3c
trying to fix the include pattern
ndelangen 18b4f8d
again
ndelangen 82851be
Merge branch 'next' into norbert/cli-with-ink
ndelangen f6975ff
cleanup
ndelangen ec64802
Merge branch 'next' into norbert/cli-with-ink
ndelangen 1cdcb1a
split the create-storybook CLI into a modern & legacy part, based on …
ndelangen 8c9d6af
add comments
ndelangen b5d1593
render the app
ndelangen 6423249
wip
ghengeveld cfd010a
Merge pull request #30256 from storybookjs/gert/cli-with-ink
ndelangen b6e2afe
version accurate
ndelangen b530642
scaffold reducer state
ndelangen cf905a2
adding more input
ndelangen 4b9f6cf
cleanup
ndelangen bbdae44
add more steps details
ndelangen 54b0998
add a run step && cleanup
ndelangen 9983643
add node utils via context, so storybook doesn't run into it
ndelangen d5ca217
crude install
ndelangen dcd3d1f
add require for resolving to context, use ni for package manager oper…
ndelangen a59ea66
reduce bloat
ndelangen af7ec07
fix
ndelangen 75019af
fixes & add place for metrics component
ndelangen d8fc245
handle steps as a straight line. each step can skip itself in a useEf…
ndelangen df22449
cleanup
ndelangen ab86684
I guess we can keep it
ndelangen 9c70158
move Confirm component
ndelangen 195c39f
simplify
ndelangen 8ff6e74
figured out a way to cancel
ndelangen f58c72d
track errors from procedures
ndelangen 4817715
more error handling in interllation procedure
ndelangen 3fe3307
better error handling
ndelangen a4c188e
improve error handling (no meaningless error if a meaningful one was …
ndelangen 212b99f
install with versions & improve UI
ndelangen 4bf774d
improve UI
ndelangen 924fb94
uppercase to indicate <enter> will select that
ndelangen 133f948
refactor, to reduce long files
ndelangen 3de4555
move check to context
ndelangen dde08df
more stories
ndelangen 9dc465b
cleanup
ndelangen 25e2024
cleanup
ndelangen d41f56d
context changes
ndelangen 1276642
fixes
ndelangen 10bf2e7
fixes
ndelangen d9f0590
fix
ndelangen 076929d
add story
ndelangen 03c8751
cleanup
ndelangen b28651c
Add telemetry
ghengeveld 174473c
improve
ndelangen 6443b00
Omit directory for privacy reasons
ghengeveld 2a2f9b0
Rename files
ghengeveld dbdb3a1
Merge branch 'norbert/cli-with-ink' into gert/init-telemetry
ghengeveld 2ad4e6f
Merge pull request #30313 from storybookjs/gert/init-telemetry
ghengeveld 17eb077
fix
ndelangen 68fd581
fix
ndelangen d281b9a
improve error handling
ndelangen 3114096
cleanup
ndelangen 23379b3
cleanup
ndelangen 9e3968d
add completion & spinners to procedures && add telemetry as tracked task
ndelangen 5b2bbab
have some fun, I got the user's name
ndelangen db1e037
improve header
ndelangen 90f0a74
improve error handling of installation
ndelangen 4958640
fixes
ndelangen 89c404c
fix typo
ndelangen e003420
Merge branch 'next' into norbert/cli-with-ink
ndelangen 8b13cb1
Disable telemetry notification when running create-storybook because …
ghengeveld 7a167e0
Implement checks
ghengeveld 16a7433
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 958e81e
fix intents
ndelangen 7ea83ed
no default in CLI, but set defaults in the component instead. This wa…
ndelangen 1a6be9c
no default intents in app
ndelangen 3159795
Implement first set of actual checks
ghengeveld 7044963
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen fb670b9
Merge branch 'next' into norbert/cli-with-ink
ndelangen e8d1fdf
add crude config generation
ndelangen 8a58dbe
add main config generation
ndelangen da9991b
improve config generation
ndelangen 1368d0d
improve messaging of configDir check
ndelangen e9abc33
previewConfig file generation
ndelangen 5661454
Various prerequisite checks
ghengeveld 2f2472c
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 426013c
Cleanup comments
ghengeveld f83bd4b
add a map for package names
ndelangen 4302698
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 6266659
add detection
ndelangen 29e75e1
I suppose we could do it like this
ndelangen e858811
add cwd
ndelangen 6b9ec5d
Wrapup Vitest compatibility checks
ghengeveld 6f059c1
Add new compatibility checks to old create-storybook CLI
ghengeveld a594eea
Fix installation process
ghengeveld 8468f6f
remove unused ink
ndelangen 88f3cbc
Merge branch 'next' into norbert/cli-with-ink
ndelangen ef2f0e6
make intents question optional && more cleanup
ndelangen c3b2f8b
improve check
ndelangen 46771c5
cleanup
ndelangen f4f1e3b
fix typing
ndelangen 457a447
cleanup
ndelangen 1c0dd49
fix
ndelangen 9028541
do not run on CI
ndelangen 6a6e89b
Merge branch 'next' into norbert/cli-with-ink
ndelangen e433a08
cleanup
ndelangen 6867b54
add intents to telemetry
ndelangen da37286
cleanup
ndelangen 8e0d959
cleanup
ndelangen fe2dc28
cleanup
ndelangen 5bad95b
cleanup
ndelangen 2a2806f
prebundle create-storybook more
ndelangen 2ff6044
remove prettier as a dependency
ndelangen 5adcfd5
direct depend on storybook/core
ndelangen d43667d
fix forgotten usages of storybook/internal
ndelangen 43029f5
Add support for extending existing Vitest workspace file
ghengeveld dc10757
Handle non-interactive (non TTY) mode
ghengeveld 35656f0
add CLi flag for intents & send original intent to telemetry
ndelangen 78a2d72
Don't default to migrating to nextjs-vite
ghengeveld 0063c5e
Check for framework compatibility with addon-test
ghengeveld 8c13344
Force storybook package version for sb add command
ghengeveld 985843b
Avoid caret syntax in addon version string when using PR canary
ghengeveld 1dd4f35
Move templates to directory and include them in dist
ghengeveld 14b609a
remove dependency on core from create-storybook
ndelangen 96c4ab2
ignore some types issues, not generate types for create-storybook
ndelangen fa56300
cleanup
ndelangen 35224f1
fixes
ndelangen 9b97c5d
deal with no linting in test
ndelangen d4531ab
Merge branch 'next' into norbert/cli-with-ink
ndelangen 674194b
fix checks
ndelangen 7ef841f
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 3cd19d6
skip failing test
ndelangen b4de21b
knip fix
ndelangen b701414
large
ndelangen a9d4f39
move templates to top-level package
ndelangen eecb7f3
cleanup
ndelangen e08bf93
Update existing config file and only fall back to creating a workspac…
ghengeveld 078ba9c
Move templates to addon root so we don't need to copy it to dist
ghengeveld 6decde5
Fix template path
ghengeveld 09ccce4
add semver to regular deps
ndelangen a2a9f27
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 8b1aa95
do not install addon-interactions when test intent is set, as it will…
ndelangen 3d1a386
fixes
ndelangen fe0a73b
try both panel names
ndelangen ec2e1a2
more
ndelangen 7f2ab10
fix e2e test for addon-interactions by skipping them wheb appropriate
ndelangen f787874
do not add experimental-addon-test when non interactive CLI, this is …
ndelangen c99a686
add extra CI step to test intents
ndelangen ff5316e
fix
ndelangen 4e104e6
fix
ndelangen baec739
in one step...
ndelangen 0b7a8e6
Refactor sandbox setup to write either workspace or config file based…
ghengeveld cbc93ee
add extends true, as @JReinhold suggested
ndelangen a3a3440
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen ccae917
Merge branch 'next' into norbert/cli-with-ink
ndelangen c7599ae
Support updating Vite config with test property, and check for Vitest…
ghengeveld 46bc666
fix checks
ndelangen e4c4b31
Fix EXTENDS_WORKSPACE template value
ghengeveld ce2f2ae
add jiti to root
ndelangen 566c28c
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen a30ec76
update test
ndelangen 2875796
Merge branch 'next' into norbert/cli-with-ink
ndelangen 6fd5f85
fix review comment https://github.com/storybookjs/storybook/pull/3020…
ndelangen 6dc6aa4
fix review comments
ndelangen 2847a36
remove comment
ndelangen 68ed7a9
Remove commented-out code related to Ink-based CLI
ghengeveld 2b2f47e
Merge branch 'next' into norbert/cli-with-ink
ndelangen 270bfed
Merge branch 'norbert/cli-with-ink' of https://github.com/storybookjs…
ndelangen 615ffa5
cleanup
ndelangen 26847e8
merge in next
ndelangen d564e1a
cleanup
ndelangen e6c0ba8
Merge branch 'next' into norbert/cli-with-ink
ndelangen ad7a5a0
rename intents to features
ndelangen 2abf798
Check for project type compatibility with addon-test _after_ promptin…
ghengeveld 865a0c0
Disable docs if docs feature is not selected and omit docs entries if…
ghengeveld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
do not run on CI
commit 90285413d13af797c15ffac31f881690ec342d4f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: use packageManager.add() instead of execSync for consistency with rest of codebase