Revert "fix: update throttle" #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #869
Causes https://storyblok.atlassian.net/browse/SHAPE-7690
Multiple clients reports that the CLI is suddenly failing.
The following commands fail
When running locally
After I deleted node_modules, I could not run the script anymoreI then discovered that the entry file has dependencies: npm: storyblok
I pinned the versions of the dependencies, and now it's working locally again.
When I go from [email protected] to [email protected] (latest), I reproduce the error
The cli does not bundle the dependencies into dist, but declares them in package.json and imports them. Since the versions in dependencies are not pinned, users can get different results depending on how their package manager resolves the dependencies