-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: provider + consumer + subscription #746
Draft
Gozala
wants to merge
9
commits into
main
Choose a base branch
from
feat/auto-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
commented
May 2, 2023
1. Insert into `subscription` table record where | ||
- `provider` is `with` | ||
- `customer` is `nb.customer` | ||
- `order` is `nb.order` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { cid: order } = CBOR.write({ customer, consumer })
const key = `${order}@${providerDID}`
db.put(key, { provider, customer, order })
Gozala
commented
May 2, 2023
|
||
2. Insert into `consumer` table records where | ||
- `subscription` is `${nb.order}@${with}` | ||
- `consumer` is `*` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { with: provider, nb: { consumer, order } } = invocation.capability
db.consumer.put(`${order}@${provider}`, { consumer, order, provider })
travis
added a commit
to storacha/w3infra
that referenced
this pull request
May 23, 2023
…mer tables (#200) Implement the subscription and consumer tables specified by @Gozala in storacha/w3up#746 and use them to implement a new version of ProvisionStorage This builds on a PR review from @Gozala that lays out some of the queries we will need to support with these new tables: #194 (review) This is configured to merge into the main "D1 to Dynamo" development branch - I'm in favor of going to production with this implementation of `ProvisionStorage` rather than the one in that branch now.
travis
added a commit
to storacha/w3infra
that referenced
this pull request
Jun 2, 2023
rework the indexes of the subscription and consumer tables per his guidance in storacha/w3up#746 (comment)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.