Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the value of the
aria-modal
attribute based on the value of theblocking
prop. According to the MDN Web Docs thearia-modal
attribute is designed to limit screen readers to a particular area of an application. Therefore I think it makes sense that it should be set in line with theblocking
prop.Without this fix there is no way to set
aria-modal
tofalse
therefore screen readers which respect the attribute (currently only iOS as far as I know) will always be stuck in the bottom sheet.