Return Etag value from saveToS3 method (#24)

* Return Etag from saveToS3 method * Update Tests
stefanzweifel · Jul 15, 2022 · 2ba11a1 · 2ba11a1
1 parent e538f16
commit 2ba11a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/BrowsershotLambda.php b/src/BrowsershotLambda.php
@@ -60,7 +60,7 @@ protected function throwError(SettledResult $response): void
     /**
      * @throws CouldNotTakeBrowsershot
      */
-    public function saveToS3(string $targetPath, string $disk = 's3')
+    public function saveToS3(string $targetPath, string $disk = 's3'): string
     {
         $this->setOption('s3', [
             'path' => $targetPath,
@@ -83,5 +83,7 @@ public function saveToS3(string $targetPath, string $disk = 's3')
         if (empty($output)) {
             throw CouldNotTakeBrowsershot::chromeOutputEmpty("$targetPath on S3 disk: $disk", $output, $command);
         }
+
+        return $output;
     }
 }
diff --git a/tests/BrowsershotLambdaTest.php b/tests/BrowsershotLambdaTest.php
@@ -83,7 +83,9 @@
 it('stores pdf in s3 bucket', function () {
     $this->assertFalse(Storage::disk('s3')->exists('example.pdf'));
 
-    BrowsershotLambda::url('https://example.com')->saveToS3('example.pdf');
+    $etag = BrowsershotLambda::url('https://example.com')->saveToS3('example.pdf');
+
+    $this->assertIsString($etag);
 
     $this->assertTrue(Storage::disk('s3')->exists('example.pdf'));
     Storage::disk('s3')->delete('example.pdf');